media: ipu6: Fix typo and wrong constant in ipu6-mmu.c

Fix two coding errors in ipu6-mmu.c:

1. Fix syntax error in page_table_dump() where the closing parenthesis
   and semicolon were swapped in the TBL_PHYS_ADDR macro call.

2. Fix incorrect loop bound in alloc_l2_pt(). When initializing L2 page
   table entries, the loop was incorrectly using ISP_L1PT_PTES instead
   of ISP_L2PT_PTES.

Fixes: 9163d83573e4 ("media: intel/ipu6: add IPU6 DMA mapping API and MMU table")
Cc: stable@vger.kernel.org
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/pci/intel/ipu6/ipu6-mmu.c b/drivers/media/pci/intel/ipu6/ipu6-mmu.c
index 6d1c0b90169d4086cfa010bdda80ee61c445d90f..85cc6d5b4dd11e0a389e8bb3ae8aa2a1d3d36c11 100644 (file)
--- a/drivers/media/pci/intel/ipu6/ipu6-mmu.c
+++ b/drivers/media/pci/intel/ipu6/ipu6-mmu.c
@@ -102,7 +102,7 @@ static void page_table_dump(struct ipu6_mmu_info *mmu_info)
                if (mmu_info->l1_pt[l1_idx] == mmu_info->dummy_l2_pteval)
                        continue;
 
-               l2_phys = TBL_PHYS_ADDR(mmu_info->l1_pt[l1_idx];)
+               l2_phys = TBL_PHYS_ADDR(mmu_info->l1_pt[l1_idx]);
                dev_dbg(mmu_info->dev,
                        "l1 entry %u; iovas 0x%8.8x-0x%8.8x, at %pap\n",
                        l1_idx, iova, iova + ISP_PAGE_SIZE, &l2_phys);
@@ -248,7 +248,7 @@ static u32 *alloc_l2_pt(struct ipu6_mmu_info *mmu_info)
 
        dev_dbg(mmu_info->dev, "alloc_l2: get_zeroed_page() = %p\n", pt);
 
-       for (i = 0; i < ISP_L1PT_PTES; i++)
+       for (i = 0; i < ISP_L2PT_PTES; i++)
                pt[i] = mmu_info->dummy_page_pteval;
 
        return pt;