]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
Add test for unicode domain and path arguments to set_cookie
authorBen Darnell <ben@bendarnell.com>
Wed, 22 Jun 2011 03:43:14 +0000 (20:43 -0700)
committerBen Darnell <ben@bendarnell.com>
Wed, 22 Jun 2011 03:43:14 +0000 (20:43 -0700)
tornado/test/web_test.py

index f02d31f2c2db9a3cef6eac1c4754754b51309ee4..ae1955f79f49cad89d4ab268b6623a2231a1d68b 100644 (file)
@@ -65,9 +65,18 @@ class CookieTest(AsyncHTTPTestCase, LogTrapTestCase):
             def get(self):
                 self.write(self.get_cookie("foo"))
 
+        class SetCookieDomainHandler(RequestHandler):
+            def get(self):
+                # unicode domain and path arguments shouldn't break things
+                # either (see bug #285)
+                self.set_cookie("unicode_args", "blah", domain=u"foo.com",
+                                path=u"/foo")
+
+
         return Application([
                 ("/set", SetCookieHandler),
-                ("/get", GetCookieHandler)])
+                ("/get", GetCookieHandler),
+                ("/set_domain", SetCookieDomainHandler)])
 
     def test_set_cookie(self):
         response = self.fetch("/set")
@@ -80,6 +89,11 @@ class CookieTest(AsyncHTTPTestCase, LogTrapTestCase):
         response = self.fetch("/get", headers={"Cookie": "foo=bar"})
         self.assertEqual(response.body, b("bar"))
 
+    def test_set_cookie_domain(self):
+        response = self.fetch("/set_domain")
+        self.assertEqual(response.headers.get_list("Set-Cookie"),
+                         ["unicode_args=blah; Domain=foo.com; Path=/foo"])
+
 class AuthRedirectRequestHandler(RequestHandler):
     def initialize(self, login_url):
         self.login_url = login_url