]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
CVE-2020-25722 s4/cracknames: lookup_spn_alias doesn't need krb5 context
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Tue, 10 Aug 2021 23:02:36 +0000 (23:02 +0000)
committerJule Anger <janger@samba.org>
Mon, 8 Nov 2021 09:52:11 +0000 (10:52 +0100)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14564

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/cracknames.c

index 7336778ec533c9492b146b4aeb29bc0b8404cae8..235276bc4c87684aeb57d13b1fcb2f30b73a25a7 100644 (file)
@@ -72,9 +72,9 @@ static WERROR dns_domain_from_principal(TALLOC_CTX *mem_ctx, struct smb_krb5_con
 
        info1->status = DRSUAPI_DS_NAME_STATUS_DOMAIN_ONLY;
        return WERR_OK;
-}              
+}
 
-static enum drsuapi_DsNameStatus LDB_lookup_spn_alias(krb5_context context, struct ldb_context *ldb_ctx, 
+static enum drsuapi_DsNameStatus LDB_lookup_spn_alias(struct ldb_context *ldb_ctx,
                                                      TALLOC_CTX *mem_ctx,
                                                      const char *alias_from,
                                                      char **alias_to)
@@ -219,8 +219,7 @@ static WERROR DsCrackNameSPNAlias(struct ldb_context *sam_ctx, TALLOC_CTX *mem_c
        dns_name = (const char *)component->data;
 
        /* MAP it */
-       namestatus = LDB_lookup_spn_alias(smb_krb5_context->krb5_context, 
-                                         sam_ctx, mem_ctx, 
+       namestatus = LDB_lookup_spn_alias(sam_ctx, mem_ctx,
                                          service, &new_service);
 
        if (namestatus == DRSUAPI_DS_NAME_STATUS_NOT_FOUND) {