]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rbd: use GFP_NOIO in rbd_obj_request_create()
authorIlya Dryomov <idryomov@gmail.com>
Wed, 24 Jun 2015 14:24:33 +0000 (17:24 +0300)
committerSasha Levin <sasha.levin@oracle.com>
Sun, 5 Jul 2015 14:12:55 +0000 (10:12 -0400)
[ Upstream commit 5a60e87603c4c533492c515b7f62578189b03c9c ]

rbd_obj_request_create() is called on the main I/O path, so we need to
use GFP_NOIO to make sure allocation doesn't blow back on us.  Not all
callers need this, but I'm still hardcoding the flag inside rather than
making it a parameter because a) this is going to stable, and b) those
callers shouldn't really use rbd_obj_request_create() and will be fixed
in the future.

More memory allocation fixes will follow.

Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/block/rbd.c

index 5d684d97dc6dfc6e3dda5fd9a66e27c9d69dd7c6..501a8ca662f45ceaa8e837d7c0fef9937267e236 100644 (file)
@@ -1998,11 +1998,11 @@ static struct rbd_obj_request *rbd_obj_request_create(const char *object_name,
        rbd_assert(obj_request_type_valid(type));
 
        size = strlen(object_name) + 1;
-       name = kmalloc(size, GFP_KERNEL);
+       name = kmalloc(size, GFP_NOIO);
        if (!name)
                return NULL;
 
-       obj_request = kmem_cache_zalloc(rbd_obj_request_cache, GFP_KERNEL);
+       obj_request = kmem_cache_zalloc(rbd_obj_request_cache, GFP_NOIO);
        if (!obj_request) {
                kfree(name);
                return NULL;