]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: apple: rtkit: Add and use PWR_STATE_INIT instead of _ON
authorJanne Grunau <j@jannau.net>
Wed, 26 Feb 2025 19:00:03 +0000 (19:00 +0000)
committerSven Peter <sven@svenpeter.dev>
Fri, 28 Feb 2025 21:36:45 +0000 (21:36 +0000)
This state is needed to wake the dcp IOP after m1n1 shut it down
and works for all other co-processors as well.

Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://lore.kernel.org/r/20250226-apple-soc-misc-v2-1-c3ec37f9021b@svenpeter.dev
Signed-off-by: Sven Peter <sven@svenpeter.dev>
drivers/soc/apple/rtkit.c

index 2f5f878bf899b806351cbd73b12eeb12a7a53946..be0d08861168ec3359d84d43f1d262be898eb8a2 100644 (file)
@@ -12,6 +12,7 @@ enum {
        APPLE_RTKIT_PWR_STATE_IDLE = 0x201, /* sleeping, retain state */
        APPLE_RTKIT_PWR_STATE_QUIESCED = 0x10, /* running but no communication */
        APPLE_RTKIT_PWR_STATE_ON = 0x20, /* normal operating state */
+       APPLE_RTKIT_PWR_STATE_INIT = 0x220, /* init after starting the coproc */
 };
 
 enum {
@@ -898,7 +899,7 @@ int apple_rtkit_wake(struct apple_rtkit *rtk)
         * Use open-coded apple_rtkit_set_iop_power_state since apple_rtkit_boot
         * will wait for the completion anyway.
         */
-       msg = FIELD_PREP(APPLE_RTKIT_MGMT_PWR_STATE, APPLE_RTKIT_PWR_STATE_ON);
+       msg = FIELD_PREP(APPLE_RTKIT_MGMT_PWR_STATE, APPLE_RTKIT_PWR_STATE_INIT);
        ret = apple_rtkit_management_send(rtk, APPLE_RTKIT_MGMT_SET_IOP_PWR_STATE,
                                          msg);
        if (ret)