]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: ftgmac100: Simplify legacy MDIO setup
authorAndrew Lunn <andrew@lunn.ch>
Fri, 6 Feb 2026 03:17:50 +0000 (11:17 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 10 Feb 2026 12:40:50 +0000 (13:40 +0100)
There are old device trees which place the PHY nodes directly in the
MAC nodes, rather than within an MDIO container node.

The probe logic indicates that the use of NCSI and the legacy
placement of PHYs is mutually exclusive. Hence priv->use_ncsi cannot
be true, so there is no reason to set it false.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
Link: https://patch.msgid.link/20260206-ftgmac-cleanup-v5-10-ad28a9067ea7@aspeedtech.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/faraday/ftgmac100.c

index c33726e7bff68ea980d704c4ba541cea889c9131..ee886ed03587df68bd56be0530d6c97ba5f28fb7 100644 (file)
@@ -2010,8 +2010,6 @@ static int ftgmac100_probe(struct platform_device *pdev)
                 * child node. Automatically scan the MDIO bus for available
                 * PHYs.
                 */
-               priv->use_ncsi = false;
-
                err = ftgmac100_mii_probe(netdev);
                if (err) {
                        dev_err(priv->dev, "MII probe failed!\n");