Bug 365926: Serve attachments without an explicit charset, and let the browser

decide which charset to use
r=LpSolit, a=LpSolit

diff --git a/attachment.cgi b/attachment.cgi
index 0181f8cad72698c9608dd239b8021064cfe47875..f85fb3a19edb7962cd4659809e559c1587da38c6 100755 (executable)
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -329,6 +329,14 @@ sub view {
 
     my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment';
 
+    # Don't send a charset header with attachments--they might not be UTF-8.
+    # However, we do allow people to explicitly specify a charset if they
+    # want.
+    if ($contenttype !~ /\bcharset=/i) {
+        # In order to prevent Apache from adding a charset, we have to send a
+        # charset that's a single space.
+        $cgi->charset(' ');
+    }
     print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
                        -content_disposition=> "$disposition; filename=\"$filename\"",
                        -content_length => $attachment->datasize);