]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/bytemath: fix u32 buffer size logic
authorVictor Julien <vjulien@oisf.net>
Mon, 18 Dec 2023 07:04:52 +0000 (08:04 +0100)
committerVictor Julien <victor@inliniac.net>
Mon, 8 Jan 2024 19:23:28 +0000 (20:23 +0100)
Remove u16 cast. Remove debug assert for u16 size.

In 83ed2c3b97925d390c2a57fdc8eea52f7d3d2e4c the input was changed to
u32

src/detect-engine-content-inspection.c

index b204d1edaa7e9c5506406850b722a95ac0855c68..a4fa5c72b7d7d4e46040f4fa0e5249fa3d9a2601 100644 (file)
@@ -594,8 +594,7 @@ static int DetectEngineContentInspectionInternal(DetectEngineThreadCtx *det_ctx,
             nbytes = bmd->nbytes;
         }
 
-        DEBUG_VALIDATE_BUG_ON(buffer_len > UINT16_MAX);
-        if (DetectByteMathDoMatch(det_ctx, bmd, s, buffer, (uint16_t)buffer_len, nbytes, rvalue,
+        if (DetectByteMathDoMatch(det_ctx, bmd, s, buffer, buffer_len, nbytes, rvalue,
                     &det_ctx->byte_values[bmd->local_id], endian) != 1) {
             goto no_match;
         }