]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: mpt3sas: Fix a fw_event memory leak
authorTomas Henzl <thenzl@redhat.com>
Wed, 23 Jul 2025 15:30:18 +0000 (17:30 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Jul 2025 01:06:38 +0000 (21:06 -0400)
In _mpt3sas_fw_work() the fw_event reference is removed, it should also
be freed in all cases.

Fixes: 4318c7347847 ("scsi: mpt3sas: Handle NVMe PCIe device related events generated from firmware.")
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Link: https://lore.kernel.org/r/20250723153018.50518-1-thenzl@redhat.com
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_scsih.c

index d7d8244dfedc548949204e4007e9bf3efb5cfd6f..967af259118e72df4dc76feacdd660be30037059 100644 (file)
@@ -10809,8 +10809,7 @@ _mpt3sas_fw_work(struct MPT3SAS_ADAPTER *ioc, struct fw_event_work *fw_event)
                break;
        case MPI2_EVENT_PCIE_TOPOLOGY_CHANGE_LIST:
                _scsih_pcie_topology_change_event(ioc, fw_event);
-               ioc->current_event = NULL;
-               return;
+               break;
        }
 out:
        fw_event_work_put(fw_event);