]> git.ipfire.org Git - pakfire.git/commitdiff
solutions: Stop acting as a linked list
authorMichael Tremer <michael.tremer@ipfire.org>
Fri, 2 Jul 2021 16:24:07 +0000 (16:24 +0000)
committerMichael Tremer <michael.tremer@ipfire.org>
Fri, 2 Jul 2021 16:24:07 +0000 (16:24 +0000)
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
src/libpakfire/include/pakfire/solution.h
src/libpakfire/libpakfire.sym
src/libpakfire/solution.c

index 561006e530ece0daad3941ebe7f2aaa63fa41aae..268a6179d1aa17ec4029f6d3aacde774ad5bad12 100644 (file)
@@ -32,9 +32,6 @@ int pakfire_solution_create(struct pakfire_solution** solution,
 struct pakfire_solution* pakfire_solution_ref(struct pakfire_solution* solution);
 struct pakfire_solution* pakfire_solution_unref(struct pakfire_solution* solution);
 
-struct pakfire_solution* pakfire_solution_next(struct pakfire_solution* solution);
-void pakfire_solution_append(struct pakfire_solution* solution, struct pakfire_solution* new_solution);
-
 char* pakfire_solution_to_string(struct pakfire_solution* solution);
 
 #endif /* PAKFIRE_SOLUTION_H */
index 39ec9f29c0dff6bf4d72709c18492b08326c3b79..e6351e98c5fad86848df5e1b82bdb30e248cf7c5 100644 (file)
@@ -299,7 +299,6 @@ global:
 
        # solution
        pakfire_solution_create;
-       pakfire_solution_next;
        pakfire_solution_ref;
        pakfire_solution_to_string;
        pakfire_solution_unref;
index 841150f40ee9a3906308780eedfb33582daedf1a..c91806d43ee0d1fb3cd2efc53100c5e05f37797a 100644 (file)
@@ -38,8 +38,6 @@ struct pakfire_solution {
        struct pakfire_problem* problem;
        Id id;
        char** elements;
-
-       struct pakfire_solution* next;
 };
 
 static void import_elements(struct pakfire_solution* solution) {
@@ -149,9 +147,6 @@ PAKFIRE_EXPORT struct pakfire_solution* pakfire_solution_ref(struct pakfire_solu
 static void pakfire_solution_free(struct pakfire_solution* solution) {
        pakfire_unref(solution->pakfire);
 
-       if (solution->next)
-               pakfire_solution_unref(solution->next);
-
        pakfire_problem_unref(solution->problem);
 
        if (solution->elements)
@@ -172,21 +167,6 @@ PAKFIRE_EXPORT struct pakfire_solution* pakfire_solution_unref(struct pakfire_so
        return NULL;
 }
 
-PAKFIRE_EXPORT struct pakfire_solution* pakfire_solution_next(struct pakfire_solution* solution) {
-       return solution->next;
-}
-
-PAKFIRE_EXPORT void pakfire_solution_append(struct pakfire_solution* solution, struct pakfire_solution* new_solution) {
-       struct pakfire_solution* next;
-
-       // Go to last problem in list
-       while ((next = pakfire_solution_next(solution)) != NULL) {
-               solution = next;
-       }
-
-       solution->next = pakfire_solution_ref(new_solution);
-}
-
 static size_t count_elements_length(struct pakfire_solution* solution) {
        size_t length = 0;