]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MEDIUM: h2: properly send the GOAWAY frame in the mux
authorWilly Tarreau <w@1wt.eu>
Tue, 7 Nov 2017 10:03:01 +0000 (11:03 +0100)
committerWilly Tarreau <w@1wt.eu>
Tue, 7 Nov 2017 10:03:01 +0000 (11:03 +0100)
A typo on a condition prevented H2_CS_ERROR from being processed,
leading to an infinite loop on connection error.

src/mux_h2.c

index 28b16848926b2eea423091c599d043895428db8d..aea1f98d8bfcdb4367621902b7473cc226c983ee 100644 (file)
@@ -1871,7 +1871,7 @@ static int h2_process_mux(struct h2c *h2c)
        }
 
  fail:
-       if (unlikely(h2c->st0 > H2_CS_ERROR)) {
+       if (unlikely(h2c->st0 >= H2_CS_ERROR)) {
                if (h2c->st0 == H2_CS_ERROR) {
                        if (h2c->max_id >= 0) {
                                h2c_send_goaway_error(h2c, NULL);