]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
backup: tiny code improvements (Coverity)
authorDaniel Salzman <daniel.salzman@nic.cz>
Wed, 26 Aug 2020 12:19:10 +0000 (14:19 +0200)
committerDaniel Salzman <daniel.salzman@nic.cz>
Wed, 26 Aug 2020 12:31:17 +0000 (14:31 +0200)
src/knot/conf/conf.c
src/knot/zone/backup.c

index af2597b56029752ceb7f6ebcea956555fa6949be..0ebeda51c712b819199ceef918d29d9c6915f5af 100644 (file)
@@ -837,6 +837,10 @@ conf_mod_id_t* conf_mod_id(
 void conf_free_mod_id(
        conf_mod_id_t *mod_id)
 {
+       if (mod_id == NULL) {
+               return;
+       }
+
        free(mod_id->name);
        free(mod_id->data);
        free(mod_id);
index 3f1480293b5f48d15c40a14a70996bfbf007a0d9..9b1f150a9a2e6b6bcf44c6e9cdc67f33975e08f5 100644 (file)
@@ -182,7 +182,7 @@ static int backup_keystore(conf_t *conf, zone_t *zone, zone_backup_ctx_t *ctx)
        }
 
        char kasp_dir[strlen(ctx->backup_dir) + 6];
-       snprintf(kasp_dir, sizeof(kasp_dir), "%s/keys", ctx->backup_dir);
+       (void)snprintf(kasp_dir, sizeof(kasp_dir), "%s/keys", ctx->backup_dir);
        ret = keystore_load("keys", KEYSTORE_BACKEND_PEM, kasp_dir, &to);
        if (ret != KNOT_EOK) {
                goto done;