handler->identity can be const

and it's already parented from handler, so we don't need to
explicitly free it

diff --git a/src/modules/rlm_eap/eap.h b/src/modules/rlm_eap/eap.h
index b487c086508d9e01b13079e61bb679e21b99185a..849d1c6d68975ca41b6284f2b4286040a55f6731 100644 (file)
--- a/src/modules/rlm_eap/eap.h
+++ b/src/modules/rlm_eap/eap.h
@@ -103,7 +103,7 @@ typedef struct _eap_handler {
 
        REQUEST         *request;
 
-       char            *identity;      //!< User name from EAP-Identity
+       char const      *identity;      //!< User name from EAP-Identity
 
        EAP_DS          *prev_eapds;
        EAP_DS          *eap_ds;

diff --git a/src/modules/rlm_eap/mem.c b/src/modules/rlm_eap/mem.c
index 988b28474bc7e683cdde2d16a2f2de67ed314ca3..270721bc72eebd1fd53a25e905b9558e0130329b 100644 (file)
--- a/src/modules/rlm_eap/mem.c
+++ b/src/modules/rlm_eap/mem.c
@@ -78,11 +78,6 @@ void eap_ds_free(EAP_DS **eap_ds_p)
 
 static int _eap_handler_free(eap_handler_t *handler)
 {
-       if (handler->identity) {
-               talloc_free(handler->identity);
-               handler->identity = NULL;
-       }
-
        if (handler->prev_eapds) eap_ds_free(&(handler->prev_eapds));
        if (handler->eap_ds) eap_ds_free(&(handler->eap_ds));