]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
bin/pwclient: fix spurious except catch
authorYann E. MORIN <yann.morin.1998@free.fr>
Sun, 25 Sep 2016 10:48:32 +0000 (12:48 +0200)
committerStephen Finucane <stephenfinucane@hotmail.com>
Sun, 25 Sep 2016 15:19:23 +0000 (16:19 +0100)
The 'with' statement does not start an exception block like 'try' would,
so we get an error executing pwclient:

      File "/home/ymorin/bin/pwclient", line 300
        except IOError:
             ^
    SyntaxError: invalid syntax

Instead, don't try to catch any exception: any failure will be
propagated back up the stack and eventually cause an abort, which is
anyway what the except clause was trying to do.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Stephen Finucane <stephenfinucane@hotmail.com>
Reviewed-by: Stephen Finucane <stephenfinucane@hotmail.com>
patchwork/bin/pwclient

index b63db5362c21344e9082d2e0a36a49ac02e6cae7..ce18e541a7a43379302c656f1437a3815f395777 100755 (executable)
@@ -297,9 +297,6 @@ def action_get(rpc, patch_id):
     with open(fname, 'w') as f:
         f.write(unicode(s).encode("utf-8"))
         print('Saved patch to %s' % fname)
-    except IOError:
-        sys.stderr.write("Failed to write to %s\n" % fname)
-        sys.exit(1)
 
 
 def action_apply(rpc, patch_id, apply_cmd=None):