]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: dac: ad5504: Fix alignment for DMA safety
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 May 2022 17:56:27 +0000 (18:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:41:30 +0000 (14:41 +0200)
[ Upstream commit 00b9737caa5aaed5cf45a7c7498edf5957efa3b2 ]

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Fixes: 0dbe59c7a788 ("iio:ad5504: Do not store transfer buffers on the stack")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-48-jic23@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/dac/ad5504.c

index 8507573aa13e98c088288b473aef5afa3b317a14..e472c9564edf7fe8cff25cf30e13738a76fcda41 100644 (file)
@@ -54,7 +54,7 @@ struct ad5504_state {
        unsigned                        pwr_down_mask;
        unsigned                        pwr_down_mode;
 
-       __be16                          data[2] ____cacheline_aligned;
+       __be16                          data[2] __aligned(IIO_DMA_MINALIGN);
 };
 
 /*