]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
don't do double unlock
authorAlan T. DeKok <aland@freeradius.org>
Tue, 30 May 2017 13:14:30 +0000 (09:14 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Tue, 30 May 2017 13:14:30 +0000 (09:14 -0400)
CID #1020958

src/modules/rlm_sql/drivers/rlm_sql_firebird/rlm_sql_firebird.c

index 7c6de4067b383eb85e748a687191b95b93ed3392..2717149170d97226fcccc2f47ce2dc9f45d8de00 100644 (file)
@@ -124,7 +124,6 @@ static sql_rcode_t sql_query(rlm_sql_handle_t *handle, UNUSED rlm_sql_config_t *
                      (long int) conn->sql_code, conn->error, query);
 
                if (conn->sql_code == DOWN_SQL_CODE) {
-               reconnect:
                        pthread_mutex_unlock(&conn->mut);
 
                        return RLM_SQL_RECONNECT;
@@ -135,7 +134,7 @@ static sql_rcode_t sql_query(rlm_sql_handle_t *handle, UNUSED rlm_sql_config_t *
                        //assume the network is down if rollback had failed
                        ERROR("Fail to rollback transaction after previous error: %s", conn->error);
 
-                       goto reconnect;
+                       return RLM_SQL_RECONNECT;
                }
                //   conn->in_use=0;