]> git.ipfire.org Git - thirdparty/git.git/commitdiff
Merge branch 'jk/reftable-leakfix' into jch
authorJunio C Hamano <gitster@pobox.com>
Tue, 30 Jun 2026 19:59:14 +0000 (12:59 -0700)
committerJunio C Hamano <gitster@pobox.com>
Tue, 30 Jun 2026 19:59:14 +0000 (12:59 -0700)
Leakfix.

* jk/reftable-leakfix:
  reftable: fix unlikely leak on API error

1  2 
reftable/writer.c

index f850e9d599e387f12c4d7f1b18834b70819cd19a,1bd4aa388beb1603f9fa7f14e1fa181a2ccbc772..d969a6a0210e8bc8e1286d799278f6d70d286845
@@@ -161,9 -158,10 +157,13 @@@ int reftable_writer_new(struct reftable
        if (opts.block_size >= (1 << 24))
                return REFTABLE_API_ERROR;
  
 +      if (!hash_id)
 +              hash_id = REFTABLE_HASH_SHA1;
 +
+       wp = reftable_calloc(1, sizeof(*wp));
+       if (!wp)
+               return REFTABLE_OUT_OF_MEMORY_ERROR;
        reftable_buf_init(&wp->block_writer_data.last_key);
        reftable_buf_init(&wp->last_key);
        reftable_buf_init(&wp->scratch);