]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
selftest/subunithelper: only let ']\n' lines to terminate
authorStefan Metzmacher <metze@samba.org>
Thu, 5 Nov 2020 13:19:11 +0000 (14:19 +0100)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 11 Nov 2020 21:14:32 +0000 (21:14 +0000)
It should not be enough that a line ends with ']\n' is accident,
subunit DETAILS are terminated with '\n]\n'!

This gives a much higher chance to see the actual problem
without having them filtered by various 'filter-subunit' invocations.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
selftest/subunithelper.py

index baab146ca60eb1b7bba2ba02e48bba89cd0b57c9..7224ddbaed53ef579bc0841ce542961125b5d85b 100644 (file)
@@ -85,8 +85,7 @@ def parse_results(msg_ops, statistics, fh):
                     if l == "":
                         break
                     msg_ops.control_msg(l)
-                    if l[-2:] == "]\n":
-                        reason += l[:-2]
+                    if l == "]\n":
                         terminated = True
                         break
                     else: