]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
block: Make REQ_OP_ZONE_FINISH a write operation
authorDamien Le Moal <dlemoal@kernel.org>
Wed, 25 Jun 2025 09:33:23 +0000 (18:33 +0900)
committerJens Axboe <axboe@kernel.dk>
Mon, 30 Jun 2025 21:50:31 +0000 (15:50 -0600)
REQ_OP_ZONE_FINISH is defined as "12", which makes
op_is_write(REQ_OP_ZONE_FINISH) return false, despite the fact that a
zone finish operation is an operation that modifies a zone (transition
it to full) and so should be considered as a write operation (albeit
one that does not transfer any data to the device).

Fix this by redefining REQ_OP_ZONE_FINISH to be an odd number (13), and
redefine REQ_OP_ZONE_RESET and REQ_OP_ZONE_RESET_ALL using sequential
odd numbers from that new value.

Fixes: 6c1b1da58f8c ("block: add zone open, close and finish operations")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20250625093327.548866-2-dlemoal@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/blk_types.h

index 3d1577f07c1c827f127e109388066ff55c8eb7dd..930daff207df2cf80cf8831e6e5a1daab225d2e9 100644 (file)
@@ -350,11 +350,11 @@ enum req_op {
        /* Close a zone */
        REQ_OP_ZONE_CLOSE       = (__force blk_opf_t)11,
        /* Transition a zone to full */
-       REQ_OP_ZONE_FINISH      = (__force blk_opf_t)12,
+       REQ_OP_ZONE_FINISH      = (__force blk_opf_t)13,
        /* reset a zone write pointer */
-       REQ_OP_ZONE_RESET       = (__force blk_opf_t)13,
+       REQ_OP_ZONE_RESET       = (__force blk_opf_t)15,
        /* reset all the zone present on the device */
-       REQ_OP_ZONE_RESET_ALL   = (__force blk_opf_t)15,
+       REQ_OP_ZONE_RESET_ALL   = (__force blk_opf_t)17,
 
        /* Driver private requests */
        REQ_OP_DRV_IN           = (__force blk_opf_t)34,