]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ice: mention fw_activate action along with devlink reload
authorJacob Keller <jacob.e.keller@intel.com>
Fri, 1 May 2026 06:37:22 +0000 (23:37 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sun, 3 May 2026 02:12:46 +0000 (19:12 -0700)
The ice driver reports a helpful status message when updating firmware
indicating what action is necessary to enable the new firmware. This is
done because some updates require power cycling or rebooting the machine
but some can be activated via devlink.

The ice driver only supports activating firmware with the specific action
of "fw_activate" a bare "devlink dev reload" will *not* update the
firmware, and will only perform driver reinitialization.

Update the status message to explicitly reflect that the reload must use
the fw_activate action.

I considered modifying the text to spell out the full command, but felt
that was both overkill and something that would belong better as part of
the user space program and not hard coded into the kernel driver output.

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260430-jk-iwl-net-next-2026-04-30-v1-11-6f27ae1cd073@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice_fw_update.c

index c143e546dd8c9680e6a56ce8b37265f8e56446e5..36314610927be609b190cadbdd92cb150d112858 100644 (file)
@@ -726,7 +726,7 @@ static int ice_finalize_update(struct pldmfw *context)
        switch (priv->reset_level) {
        case ICE_AQC_NVM_EMPR_FLAG:
                devlink_flash_update_status_notify(devlink,
-                                                  "Activate new firmware by devlink reload",
+                                                  "Activate new firmware by devlink reload action fw_activate",
                                                   NULL, 0, 0);
                break;
        case ICE_AQC_NVM_PERST_FLAG: