modinfo: skip parm entries without a name

Specially crafted/corrupt modules may have a parm/parmtype entry which
lacks the "name:" prefix. Throw a warning and skip such entries.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/451
Signed-off-by: Lucas De Marchi <demarchi@kernel.org>

diff --git a/tools/modinfo.c b/tools/modinfo.c
index 2457fd2a0a768b61d3ec7c03ffa911a70ca57f45..ff338d76fff5a2c6ba5d4f73e6514c5208d8db1c 100644 (file)
--- a/tools/modinfo.c
+++ b/tools/modinfo.c
@@ -88,6 +88,11 @@ static int process_parm(const char *key, const char *value, struct param **param
                return 0;
        }
 
+       if (colon == value) {
+               ERR("Missing param name in value \"%s\"\n", value);
+               return 0;
+       }
+
        name = value;
        namelen = colon - value;
        if (streq(key, "parm")) {