]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: smbd: hardlink_internals() never looks at src_dirfsp or dst_dirfsp.
authorJeremy Allison <jra@samba.org>
Tue, 19 Sep 2023 17:30:01 +0000 (10:30 -0700)
committerRalph Boehme <slow@samba.org>
Tue, 19 Sep 2023 18:59:34 +0000 (18:59 +0000)
Show this by sending NULL in all cases.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/smb1_nttrans.c
source3/smbd/smb1_trans2.c
source3/smbd/smb2_trans2.c

index 82578ae659666df8418298ae21cb78dd86163c50..c75a30ebbf40dd15809f26c4cde31283e4eeb895 100644 (file)
@@ -1588,9 +1588,9 @@ void reply_ntrename(struct smb_request *req)
                                                    conn,
                                                    req,
                                                    false,
-                                                   src_dirfsp,
+                                                   NULL,
                                                    smb_fname_old,
-                                                   dst_dirfsp,
+                                                   NULL,
                                                    smb_fname_new);
                        break;
                case RENAME_FLAG_COPY:
index fca781d2cd4a0c4977c4296417c948f0a17cc179..47493d57904ef746a15b66e7e56a1ecf59593cc3 100644 (file)
@@ -3861,7 +3861,7 @@ static NTSTATUS smb_set_file_unix_hlink(connection_struct *conn,
                                  conn,
                                  req,
                                  false,
-                                 src_dirfsp,
+                                 NULL,
                                  smb_fname_old,
                                  NULL, /* new_dirfsp */
                                  smb_fname_new);
index 377a484eaff5af51486328237afbfabd4c2f996b..7baf420bdd0a42b2eadd9110cf1f6887ab1bfa3c 100644 (file)
@@ -4473,7 +4473,7 @@ static NTSTATUS smb2_file_link_information(connection_struct *conn,
                                overwrite,
                                NULL, /* src_dirfsp */
                                fsp->fsp_name,
-                               dst_dirfsp, /* dst_dirfsp */
+                               NULL, /* dst_dirfsp */
                                smb_fname_dst);
 
        TALLOC_FREE(smb_fname_dst);
@@ -4571,7 +4571,7 @@ static NTSTATUS smb_file_link_information(connection_struct *conn,
                                overwrite,
                                NULL, /* src_dirfsp */
                                fsp->fsp_name,
-                               dst_dirfsp, /* dst_dirfsp */
+                               NULL, /* dst_dirfsp */
                                smb_fname_dst);
 
        TALLOC_FREE(smb_fname_dst);