]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Revert "Don't check if the client is on recursing list (requires locking) if it's...
authorWitold Kręcicki <wpk@isc.org>
Fri, 7 Feb 2020 10:00:58 +0000 (11:00 +0100)
committerWitold Kręcicki <wpk@isc.org>
Fri, 7 Feb 2020 10:00:58 +0000 (11:00 +0100)
This reverts commit 41cec3a619bd604842a1de4d6953ff2a90b239f4.

lib/ns/client.c

index e20347a7258d1587b380fc66f1249e366deffd24..ef486430173cc6f1e0529aa0907f7e7126d0dd6f 100644 (file)
@@ -183,13 +183,11 @@ ns_client_endrequest(ns_client_t *client) {
 
        CTRACE("endrequest");
 
-       if (client->state == NS_CLIENTSTATE_RECURSING) {
-               LOCK(&client->manager->reclock);
-               if (ISC_LINK_LINKED(client, rlink)) {
-                       ISC_LIST_UNLINK(client->manager->recursing, client, rlink);
-               }
-               UNLOCK(&client->manager->reclock);
+       LOCK(&client->manager->reclock);
+       if (ISC_LINK_LINKED(client, rlink)) {
+               ISC_LIST_UNLINK(client->manager->recursing, client, rlink);
        }
+       UNLOCK(&client->manager->reclock);
 
        if (client->cleanup != NULL) {
                (client->cleanup)(client);