]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: adp5585: use new line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 3 Mar 2025 13:18:31 +0000 (14:18 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 10 Mar 2025 10:52:12 +0000 (11:52 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20250303-gpiochip-set-conversion-v1-6-1d5cceeebf8b@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-adp5585.c

index 000d31f09671022e27b9087f9f01593520535b12..d5c0f1b267c82a5002b50cbb7a108166439e4785 100644 (file)
@@ -86,14 +86,16 @@ static int adp5585_gpio_get_value(struct gpio_chip *chip, unsigned int off)
        return !!(val & bit);
 }
 
-static void adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off, int val)
+static int adp5585_gpio_set_value(struct gpio_chip *chip, unsigned int off,
+                                 int val)
 {
        struct adp5585_gpio_dev *adp5585_gpio = gpiochip_get_data(chip);
        unsigned int bank = ADP5585_BANK(off);
        unsigned int bit = ADP5585_BIT(off);
 
-       regmap_update_bits(adp5585_gpio->regmap, ADP5585_GPO_DATA_OUT_A + bank,
-                          bit, val ? bit : 0);
+       return regmap_update_bits(adp5585_gpio->regmap,
+                                 ADP5585_GPO_DATA_OUT_A + bank,
+                                 bit, val ? bit : 0);
 }
 
 static int adp5585_gpio_set_bias(struct adp5585_gpio_dev *adp5585_gpio,
@@ -192,7 +194,7 @@ static int adp5585_gpio_probe(struct platform_device *pdev)
        gc->direction_input = adp5585_gpio_direction_input;
        gc->direction_output = adp5585_gpio_direction_output;
        gc->get = adp5585_gpio_get_value;
-       gc->set = adp5585_gpio_set_value;
+       gc->set_rv = adp5585_gpio_set_value;
        gc->set_config = adp5585_gpio_set_config;
        gc->can_sleep = true;