]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
storage: don't leak memory for unittests 3538/head
authorVictor Julien <victor@inliniac.net>
Fri, 26 Oct 2018 14:03:05 +0000 (16:03 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 1 Nov 2018 14:46:10 +0000 (15:46 +0100)
src/runmode-unittests.c
src/util-storage.c

index daceaf12ea4b4274264177104802a23572b0e38d..4c69f92bcc7714f489a8232cec80ed843b931252 100644 (file)
@@ -251,13 +251,13 @@ void RunUnittests(int list_unittests, const char *regex_arg)
 #endif
     SpmTableSetup();
 
+    StorageInit();
     AppLayerSetup();
 
     /* hardcoded initialization code */
     SigTableSetup(); /* load the rule keywords */
     TmqhSetup();
 
-    StorageInit();
     CIDRInit();
     SigParsePrepare();
 
index 7954f2976575a16d91ab75cf5ada8a61ecec69ea..c4e92055d56818fc77f1aede30059e70b3884d27 100644 (file)
@@ -173,8 +173,11 @@ int StorageFinalize(void)
             storage_map[entry->map.type][entry->id].Free = entry->map.Free;
         }
 
-        entry = entry->next;
+        StorageList *next = entry->next;
+        SCFree(entry);
+        entry = next;
     };
+    storage_list = NULL;
 
 #ifdef DEBUG
     for (i = 0; i < STORAGE_MAX; i++) {