]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
epoll: Add synchronous wakeup support for ep_poll_callback
authorXuewen Yan <xuewen.yan@unisoc.com>
Fri, 26 Apr 2024 08:05:48 +0000 (16:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Dec 2024 12:53:01 +0000 (13:53 +0100)
commit 900bbaae67e980945dec74d36f8afe0de7556d5a upstream.

Now, the epoll only use wake_up() interface to wake up task.
However, sometimes, there are epoll users which want to use
the synchronous wakeup flag to hint the scheduler, such as
Android binder driver.
So add a wake_up_sync() define, and use the wake_up_sync()
when the sync is true in ep_poll_callback().

Co-developed-by: Jing Xia <jing.xia@unisoc.com>
Signed-off-by: Jing Xia <jing.xia@unisoc.com>
Signed-off-by: Xuewen Yan <xuewen.yan@unisoc.com>
Link: https://lore.kernel.org/r/20240426080548.8203-1-xuewen.yan@unisoc.com
Tested-by: Brian Geffon <bgeffon@google.com>
Reviewed-by: Brian Geffon <bgeffon@google.com>
Reported-by: Benoit Lize <lizeb@google.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Cc: Brian Geffon <bgeffon@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/eventpoll.c
include/linux/wait.h

index f296ffb57d05288ac61ea140d32d4e0ac9c7c40c..6101dbe283448419519b7422f4c4a8aeceaa47b2 100644 (file)
@@ -1237,7 +1237,10 @@ static int ep_poll_callback(wait_queue_entry_t *wait, unsigned mode, int sync, v
                                break;
                        }
                }
-               wake_up(&ep->wq);
+               if (sync)
+                       wake_up_sync(&ep->wq);
+               else
+                       wake_up(&ep->wq);
        }
        if (waitqueue_active(&ep->poll_wait))
                pwake++;
index a0307b516b099ed50d7e9aca6b89e3019078b949..bc06a315653a76b434bf85cf373a13a2bf0fd984 100644 (file)
@@ -224,6 +224,7 @@ void __wake_up_pollfree(struct wait_queue_head *wq_head);
 #define wake_up_all(x)                 __wake_up(x, TASK_NORMAL, 0, NULL)
 #define wake_up_locked(x)              __wake_up_locked((x), TASK_NORMAL, 1)
 #define wake_up_all_locked(x)          __wake_up_locked((x), TASK_NORMAL, 0)
+#define wake_up_sync(x)                        __wake_up_sync(x, TASK_NORMAL)
 
 #define wake_up_interruptible(x)       __wake_up(x, TASK_INTERRUPTIBLE, 1, NULL)
 #define wake_up_interruptible_nr(x, nr)        __wake_up(x, TASK_INTERRUPTIBLE, nr, NULL)