]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: iris: implement g_selection ioctl
authorVedang Nagar <quic_vnagar@quicinc.com>
Fri, 7 Feb 2025 07:54:51 +0000 (13:24 +0530)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 7 Feb 2025 10:51:25 +0000 (11:51 +0100)
Implement the g_selection ioctl op in the driver with the necessary
hooks.

Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl>
Tested-by: Stefan Schmidt <stefan.schmidt@linaro.org> # x1e80100 (Dell XPS 13 9345)
Reviewed-by: Stefan Schmidt <stefan.schmidt@linaro.org>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/qcom/iris/iris_vidc.c

index bec965284b6eeaef0f5877a0286bc5e3f6d6e97b..92eb793cbeb71bccda35ce2126a73055267c47f3 100644 (file)
@@ -259,6 +259,33 @@ static int iris_g_fmt_vid_mplane(struct file *filp, void *fh, struct v4l2_format
        return ret;
 }
 
+static int iris_g_selection(struct file *filp, void *fh, struct v4l2_selection *s)
+{
+       struct iris_inst *inst = iris_get_inst(filp, NULL);
+
+       if (s->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
+               return -EINVAL;
+
+       switch (s->target) {
+       case V4L2_SEL_TGT_CROP_BOUNDS:
+       case V4L2_SEL_TGT_CROP_DEFAULT:
+       case V4L2_SEL_TGT_CROP:
+       case V4L2_SEL_TGT_COMPOSE_BOUNDS:
+       case V4L2_SEL_TGT_COMPOSE_PADDED:
+       case V4L2_SEL_TGT_COMPOSE_DEFAULT:
+       case V4L2_SEL_TGT_COMPOSE:
+               s->r.left = inst->crop.left;
+               s->r.top = inst->crop.top;
+               s->r.width = inst->crop.width;
+               s->r.height = inst->crop.height;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
 static struct v4l2_file_operations iris_v4l2_file_ops = {
        .owner                          = THIS_MODULE,
        .open                           = iris_open,
@@ -280,6 +307,7 @@ static const struct v4l2_ioctl_ops iris_v4l2_ioctl_ops = {
        .vidioc_g_fmt_vid_cap_mplane    = iris_g_fmt_vid_mplane,
        .vidioc_g_fmt_vid_out_mplane    = iris_g_fmt_vid_mplane,
        .vidioc_reqbufs                 = v4l2_m2m_ioctl_reqbufs,
+       .vidioc_g_selection             = iris_g_selection,
 };
 
 void iris_init_ops(struct iris_core *core)