]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
realtek: pcs: rtl931x: don't mess with autoneg 22013/head
authorJonas Jelonek <jelonek.jonas@gmail.com>
Wed, 11 Feb 2026 13:15:10 +0000 (13:15 +0000)
committerRobert Marko <robimarko@gmail.com>
Mon, 16 Feb 2026 14:43:20 +0000 (15:43 +0100)
Part of the configuration sequence for 1G operation can be identified as
setting autonegotiation to enabled for that mode. Starting from a previous
commit, this is being handled properly in the set_autoneg implementation.
Thus, remove that part from the sequence which doesn't make sense there
anymore and might just cause problems.

Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/22013
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c

index 9a1239f35138e9bb880cdbb28188790e45742dce..4e1cd984e6016a986cd3eadee0f22f7e4a101005 100644 (file)
@@ -3630,7 +3630,6 @@ static int rtpcs_931x_sds_config_fiber_1g(struct rtpcs_serdes *sds)
 {
        rtpcs_sds_write_bits(sds, 0x43, 0x12, 15, 14, 0x0);
 
-       rtpcs_sds_write_bits(sds, 0x42, 0x0, 12, 12, 0x1);
        rtpcs_sds_write_bits(sds, 0x42, 0x0, 6, 6, 0x1);
        rtpcs_sds_write_bits(sds, 0x42, 0x0, 13, 13, 0x0);