]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Skip integer division optimization for Clang
authorMatthias Kretz <m.kretz@gsi.de>
Tue, 21 Mar 2023 13:20:52 +0000 (14:20 +0100)
committerMatthias Kretz <m.kretz@gsi.de>
Tue, 21 Mar 2023 19:30:19 +0000 (20:30 +0100)
Clang ICEs on _SimdImplX86::_S_divides. The function is only working
around a missed optimization and not necessary for correctness.
Therefore, don't use it for Clang.

Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
libstdc++-v3/ChangeLog:

* include/experimental/bits/simd_detail.h: Don't define
_GLIBCXX_SIMD_WORKAROUND_PR90993 for Clang.
* include/experimental/bits/simd_x86.h (_S_divides): Remove
check for __clang__.

libstdc++-v3/include/experimental/bits/simd_detail.h
libstdc++-v3/include/experimental/bits/simd_x86.h

index 49b94decf0aa9c41b745bb553d9a26c70709a003..1fb77866bb236d83b33043e63b1dcc34f6a5a802 100644 (file)
 #endif
 
 // integer division not optimized
+#ifndef __clang__
 #define _GLIBCXX_SIMD_WORKAROUND_PR90993 1
+#endif
 
 // very bad codegen for extraction and concatenation of 128/256 "subregisters"
 // with sizeof(element type) < 8: https://godbolt.org/g/mqUsgM
index 7b8f1c664b3e78885e0d67a64083bdf9d15d9eef..28ba344c2b2084f79f7f46d80cdd9f3f118ba059 100644 (file)
@@ -1469,7 +1469,7 @@ template <typename _Abi, typename>
                [&__xf, &__yf](auto __i) _GLIBCXX_SIMD_ALWAYS_INLINE_LAMBDA
                  -> _SimdWrapper<_Float, __n_intermediate>
                {
-#if !defined __clang__ && __GCC_IEC_559 == 0
+#if __GCC_IEC_559 == 0
                  // If -freciprocal-math is active, using the `/` operator is
                  // incorrect because it may be translated to an imprecise
                  // multiplication with reciprocal. We need to use inline
@@ -1524,7 +1524,7 @@ template <typename _Abi, typename>
          */
        return _Base::_S_divides(__x, __y);
       }
-  #endif // _GLIBCXX_SIMD_WORKAROUND_PR90993
+#endif // _GLIBCXX_SIMD_WORKAROUND_PR90993
 
     // }}}
     // _S_modulus {{{