channel: Fix issues in hangup scenarios caused by frame deferral

ASTERISK-26343

Change-Id: I06dbf7366e26028251964143454a77d017bb61c8

diff --git a/include/asterisk/channel.h b/include/asterisk/channel.h
index a18591fb1396f27b4bb803b67f38cec95e9daa1a..c9e537fc32d7b1b9d1cef959020ac1193da5155f 100644 (file)
--- a/include/asterisk/channel.h
+++ b/include/asterisk/channel.h
@@ -971,6 +971,11 @@ enum {
         * frames should be deferred.
         */
        AST_FLAG_DEFER_FRAMES = (1 << 28),
+       /*!
+        * The channel is currently deferring hangup frames
+        * in addition to other frame types.
+        */
+       AST_FLAG_DEFER_HANGUP_FRAMES = (1 << 29),
 };
 
 /*! \brief ast_bridge_config flags */
@@ -4700,11 +4705,17 @@ struct ast_readq_list *ast_channel_deferred_readq(struct ast_channel *chan);
  * drop important frames. This function can be called so that important frames
  * will be deferred, rather than placed in the channel frame queue as normal.
  *
+ * Hangups are an interesting frame type. Hangups will always be detectable by
+ * a reader when a channel is deferring frames. If the defer_hangups parameter
+ * is non-zero, then the hangup frame will also be duplicated and deferred, so
+ * that the next reader of the channel will get the hangup frame, too.
+ *
  * \pre chan MUST be locked before calling
  *
  * \param chan The channel on which frames should be deferred
+ * \param defer_hangups Defer hangups in addition to other deferrable frames
  */
-void ast_channel_start_defer_frames(struct ast_channel *chan);
+void ast_channel_start_defer_frames(struct ast_channel *chan, int defer_hangups);
 
 /*!
  * \brief Stop deferring deferrable frames on this channel

diff --git a/main/autoservice.c b/main/autoservice.c
index f26d8fc9bad09865fb85c128ed5be8175c4c0729..81d267c9e0d714209cbcf530a187b49fb5848c74 100644 (file)
--- a/main/autoservice.c
+++ b/main/autoservice.c
@@ -167,7 +167,7 @@ int ast_autoservice_start(struct ast_channel *chan)
        as->orig_end_dtmf_flag = ast_test_flag(ast_channel_flags(chan), AST_FLAG_END_DTMF_ONLY) ? 1 : 0;
        if (!as->orig_end_dtmf_flag)
                ast_set_flag(ast_channel_flags(chan), AST_FLAG_END_DTMF_ONLY);
-       ast_channel_start_defer_frames(chan);
+       ast_channel_start_defer_frames(chan, 1);
        ast_channel_unlock(chan);
 
        AST_LIST_LOCK(&aslist);

diff --git a/main/channel.c b/main/channel.c
index 020d4d06e759c627e1da489e003c505f3da933c4..54b91307e32bc412eabd9e99ad97015be5aeb52c 100644 (file)
--- a/main/channel.c
+++ b/main/channel.c
@@ -1061,9 +1061,10 @@ struct ast_channel *ast_dummy_channel_alloc(void)
        return tmp;
 }
 
-void ast_channel_start_defer_frames(struct ast_channel *chan)
+void ast_channel_start_defer_frames(struct ast_channel *chan, int defer_hangups)
 {
        ast_set_flag(ast_channel_flags(chan), AST_FLAG_DEFER_FRAMES);
+       ast_set2_flag(ast_channel_flags(chan), defer_hangups, AST_FLAG_DEFER_HANGUP_FRAMES);
 }
 
 void ast_channel_stop_defer_frames(struct ast_channel *chan)
@@ -1550,7 +1551,7 @@ int ast_safe_sleep_conditional(struct ast_channel *chan, int timeout_ms, int (*c
        }
 
        ast_channel_lock(chan);
-       ast_channel_start_defer_frames(chan);
+       ast_channel_start_defer_frames(chan, 0);
        ast_channel_unlock(chan);
 
        start = ast_tvnow();
@@ -3886,9 +3887,9 @@ static struct ast_frame *__ast_read(struct ast_channel *chan, int dropaudio)
                if (ast_test_flag(ast_channel_flags(chan), AST_FLAG_DEFER_FRAMES)) {
                        AST_LIST_TRAVERSE_SAFE_BEGIN(ast_channel_readq(chan), f, frame_list) {
                                if (ast_is_deferrable_frame(f)) {
-                                       if (f->frametype == AST_FRAME_CONTROL && f->subclass.integer == AST_CONTROL_HANGUP) {
-                                               struct ast_frame *dup;
-
+                                       if(f->frametype == AST_FRAME_CONTROL && 
+                                               (f->subclass.integer == AST_CONTROL_HANGUP ||
+                                                f->subclass.integer == AST_CONTROL_END_OF_Q)) {
                                                /* Hangup is a special case. We want to defer the frame, but we also do not
                                                 * want to remove it from the frame queue. So rather than just moving the frame
                                                 * over, we duplicate it and move the copy to the deferred readq.
@@ -3898,8 +3899,12 @@ static struct ast_frame *__ast_read(struct ast_channel *chan, int dropaudio)
                                                 * when frame deferral finishes, then whoever calls ast_read() next will also get
                                                 * the hangup.
                                                 */
-                                               dup = ast_frdup(f);
-                                               AST_LIST_INSERT_TAIL(ast_channel_deferred_readq(chan), dup, frame_list);
+                                               if (ast_test_flag(ast_channel_flags(chan), AST_FLAG_DEFER_HANGUP_FRAMES)) {
+                                                       struct ast_frame *dup;
+
+                                                       dup = ast_frdup(f);
+                                                       AST_LIST_INSERT_TAIL(ast_channel_deferred_readq(chan), dup, frame_list);
+                                               }
                                        } else {
                                                AST_LIST_INSERT_TAIL(ast_channel_deferred_readq(chan), f, frame_list);
                                                AST_LIST_REMOVE_CURRENT(frame_list);
@@ -10240,7 +10245,7 @@ int ast_channel_connected_line_macro(struct ast_channel *autoservice_chan, struc
 
                ast_party_connected_line_copy(ast_channel_connected(macro_chan), connected);
        }
-       ast_channel_start_defer_frames(macro_chan);
+       ast_channel_start_defer_frames(macro_chan, 0);
        ast_channel_unlock(macro_chan);
 
        retval = ast_app_run_macro(autoservice_chan, macro_chan, macro, macro_args);
@@ -10296,7 +10301,7 @@ int ast_channel_redirecting_macro(struct ast_channel *autoservice_chan, struct a
 
                ast_party_redirecting_copy(ast_channel_redirecting(macro_chan), redirecting);
        }
-       ast_channel_start_defer_frames(macro_chan);
+       ast_channel_start_defer_frames(macro_chan, 0);
        ast_channel_unlock(macro_chan);
 
        retval = ast_app_run_macro(autoservice_chan, macro_chan, macro, macro_args);
@@ -10345,7 +10350,7 @@ int ast_channel_connected_line_sub(struct ast_channel *autoservice_chan, struct
 
                ast_party_connected_line_copy(ast_channel_connected(sub_chan), connected);
        }
-       ast_channel_start_defer_frames(sub_chan);
+       ast_channel_start_defer_frames(sub_chan, 0);
        ast_channel_unlock(sub_chan);
 
        retval = ast_app_run_sub(autoservice_chan, sub_chan, sub, sub_args, 0);
@@ -10394,7 +10399,7 @@ int ast_channel_redirecting_sub(struct ast_channel *autoservice_chan, struct ast
 
                ast_party_redirecting_copy(ast_channel_redirecting(sub_chan), redirecting);
        }
-       ast_channel_start_defer_frames(sub_chan);
+       ast_channel_start_defer_frames(sub_chan, 0);
        ast_channel_unlock(sub_chan);
 
        retval = ast_app_run_sub(autoservice_chan, sub_chan, sub, sub_args, 0);