s3:rpc:wkssvc_nt: dom_user_cmp uses NUMERIC_CMP

usr->login_time is time_t, which is often bigger than int.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 75682e397b9cf22d04a5d80252554c6b2e376793)

diff --git a/source3/rpc_server/wkssvc/srv_wkssvc_nt.c b/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
index 592e8668cd35274e947c399fc8d9015b683fa2d7..89cdeb6daa1de7ff117503426eaebd0fae625a72 100644 (file)
--- a/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
+++ b/source3/rpc_server/wkssvc/srv_wkssvc_nt.c
@@ -140,7 +140,7 @@ static int dom_user_cmp(const struct dom_usr *usr1, const struct dom_usr *usr2)
        /* Called from qsort to compare two domain users in a dom_usr_t array
         * for sorting by login time. Return >0 if usr1 login time was later
         * than usr2 login time, <0 if it was earlier */
-       return (usr1->login_time - usr2->login_time);
+       return NUMERIC_CMP(usr1->login_time, usr2->login_time);
 }
 
 /*******************************************************************