]> git.ipfire.org Git - thirdparty/wireguard-tools.git/commitdiff
wg: ipc: do not warn on unrecognized netlink attributes
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 3 Sep 2018 01:25:32 +0000 (19:25 -0600)
committerJason A. Donenfeld <Jason@zx2c4.com>
Mon, 3 Sep 2018 05:59:44 +0000 (23:59 -0600)
It makes extending things more difficult.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
src/ipc.c

index e29a939e087215d1a5812ac6d5328c392f5815a9..06590e2259cdcfda7751583e92eaa735d83889d7 100644 (file)
--- a/src/ipc.c
+++ b/src/ipc.c
@@ -95,15 +95,6 @@ static int add_next_to_inflatable_buffer(struct inflatable_buffer *buffer)
        return 0;
 }
 
-static void warn_unrecognized(const char *which)
-{
-       static bool once = false;
-       if (once)
-               return;
-       once = true;
-       fprintf(stderr, "Warning: one or more unrecognized %s attributes\n", which);
-}
-
 static FILE *userspace_interface_file(const char *interface)
 {
        struct stat sbuf;
@@ -438,8 +429,6 @@ static int userspace_get_device(struct wgdevice **out, const char *interface)
                        peer->tx_bytes = NUM(0xffffffffffffffffULL);
                else if (!strcmp(key, "errno"))
                        ret = -NUM(0x7fffffffU);
-               else
-                       warn_unrecognized("daemon");
        }
        ret = -EPROTO;
 err:
@@ -711,8 +700,6 @@ static int parse_allowedip(const struct nlattr *attr, void *data)
                if (!mnl_attr_validate(attr, MNL_TYPE_U8))
                        allowedip->cidr = mnl_attr_get_u8(attr);
                break;
-       default:
-               warn_unrecognized("netlink");
        }
 
        return MNL_CB_OK;
@@ -792,8 +779,6 @@ static int parse_peer(const struct nlattr *attr, void *data)
                break;
        case WGPEER_A_ALLOWEDIPS:
                return mnl_attr_parse_nested(attr, parse_allowedips, peer);
-       default:
-               warn_unrecognized("netlink");
        }
 
        return MNL_CB_OK;
@@ -862,8 +847,6 @@ static int parse_device(const struct nlattr *attr, void *data)
                break;
        case WGDEVICE_A_PEERS:
                return mnl_attr_parse_nested(attr, parse_peers, device);
-       default:
-               warn_unrecognized("netlink");
        }
 
        return MNL_CB_OK;