]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
cifs: add xid to query server interface call
authorShyam Prasad N <sprasad@microsoft.com>
Mon, 30 Oct 2023 11:00:08 +0000 (11:00 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Apr 2024 13:28:34 +0000 (15:28 +0200)
[ Upstream commit 4cf6e1101a25ca5e63d48adf49b0a8a64bae790f ]

We were passing 0 as the xid for the call to query
server interfaces. This is not great for debugging.
This change adds a real xid.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Reviewed-by: Bharath SM <bharathsm@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Stable-dep-of: 13c0a74747cb ("cifs: make sure server interfaces are requested only for SMB3+")
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/connect.c

index a4147e999736aecb7840602154f94606579f19fc..2a564f19dbb393e18a7f9c866e935c910c2aa6e7 100644 (file)
@@ -119,6 +119,7 @@ static int reconn_set_ipaddr_from_hostname(struct TCP_Server_Info *server)
 static void smb2_query_server_interfaces(struct work_struct *work)
 {
        int rc;
+       int xid;
        struct cifs_tcon *tcon = container_of(work,
                                        struct cifs_tcon,
                                        query_interfaces.work);
@@ -126,7 +127,10 @@ static void smb2_query_server_interfaces(struct work_struct *work)
        /*
         * query server network interfaces, in case they change
         */
-       rc = SMB3_request_interfaces(0, tcon, false);
+       xid = get_xid();
+       rc = SMB3_request_interfaces(xid, tcon, false);
+       free_xid(xid);
+
        if (rc) {
                if (rc == -EOPNOTSUPP)
                        return;