]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virNetDevVPortProfileParse: Use virXMLNodeGetSubelement to find '<parameters>'
authorPeter Krempa <pkrempa@redhat.com>
Fri, 2 Dec 2022 10:01:06 +0000 (11:01 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 6 Feb 2023 08:14:00 +0000 (09:14 +0100)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/netdev_vport_profile_conf.c

index cdde7efcd9c6b852b4a0dd040bf88061570d34d5..26f379248f8118db89f144666eed9b88c2a1ac0a 100644 (file)
@@ -36,7 +36,7 @@ virNetDevVPortProfileParse(xmlNodePtr node, unsigned int flags)
     g_autofree char *virtPortProfileID = NULL;
     g_autofree char *virtPortInterfaceID = NULL;
     g_autofree virNetDevVPortProfile *virtPort = NULL;
-    xmlNodePtr cur = node->children;
+    xmlNodePtr parameters;
 
     virtPort = g_new0(virNetDevVPortProfile, 1);
 
@@ -54,17 +54,13 @@ virNetDevVPortProfileParse(xmlNodePtr node, unsigned int flags)
         return NULL;
     }
 
-    while (cur != NULL) {
-        if (virXMLNodeNameEqual(cur, "parameters")) {
-            virtPortManagerID = virXMLPropString(cur, "managerid");
-            virtPortTypeID = virXMLPropString(cur, "typeid");
-            virtPortTypeIDVersion = virXMLPropString(cur, "typeidversion");
-            virtPortInstanceID = virXMLPropString(cur, "instanceid");
-            virtPortProfileID = virXMLPropString(cur, "profileid");
-            virtPortInterfaceID = virXMLPropString(cur, "interfaceid");
-            break;
-        }
-        cur = cur->next;
+    if ((parameters = virXMLNodeGetSubelement(node, "parameters"))) {
+        virtPortManagerID = virXMLPropString(parameters, "managerid");
+        virtPortTypeID = virXMLPropString(parameters, "typeid");
+        virtPortTypeIDVersion = virXMLPropString(parameters, "typeidversion");
+        virtPortInstanceID = virXMLPropString(parameters, "instanceid");
+        virtPortProfileID = virXMLPropString(parameters, "profileid");
+        virtPortInterfaceID = virXMLPropString(parameters, "interfaceid");
     }
 
     if (virtPortManagerID) {