]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Fix leak in krb5_krcc_unparse_cred on error
authorGreg Hudson <ghudson@mit.edu>
Fri, 2 Aug 2013 15:37:40 +0000 (11:37 -0400)
committerGreg Hudson <ghudson@mit.edu>
Fri, 2 Aug 2013 15:37:40 +0000 (11:37 -0400)
Based on a patch from simo@redhat.com.

src/lib/krb5/ccache/cc_keyring.c

index 3828c5949a54f019a7728902be9cd7cc67e6ce4a..55c7711dd49f72d7dfe090e9a741ca70e900ee96 100644 (file)
@@ -1913,7 +1913,7 @@ krb5_krcc_unparse_cred(krb5_context context, krb5_ccache id,
                        krb5_creds * creds, char **datapp, unsigned int *lenptr)
 {
     krb5_error_code kret;
-    char   *buf;
+    char *buf = NULL;
     krb5_krcc_bc bc;
 
     if (!creds || !datapp || !lenptr)
@@ -1963,9 +1963,11 @@ krb5_krcc_unparse_cred(krb5_context context, krb5_ccache id,
     /* Success! */
     *datapp = buf;
     *lenptr = bc.bpp - buf;
+    buf = NULL;
     kret = KRB5_OK;
 
 errout:
+    free(buf);
     return kret;
 }