]> git.ipfire.org Git - thirdparty/psycopg.git/commitdiff
Drop TODO point regarding Travis
authorDaniele Varrazzo <daniele.varrazzo@gmail.com>
Tue, 24 Aug 2021 21:08:29 +0000 (23:08 +0200)
committerDaniele Varrazzo <daniele.varrazzo@gmail.com>
Wed, 25 Aug 2021 01:06:06 +0000 (03:06 +0200)
On GitHub Action it's OK.

On flaky platforms these tests are skipped, so let's fail hard if the
proxy fails to come up.

tests/fix_proxy.py

index 33df7a24b95f06a0abad34ff0e4c0c2b9e08933d..83fce5c9f10c43274f7b5a1969b8d102f0dfb663 100644 (file)
@@ -82,12 +82,11 @@ class Proxy:
         self._wait_listen()
 
         # verify that the proxy works
-        # TODO: investigate why it doesn't on Travis
         try:
             with psycopg.connect(self.client_dsn):
                 pass
         except Exception as e:
-            pytest.xfail(f"failed to create a working proxy: {e}")
+            pytest.fail(f"failed to create a working proxy: {e}")
 
     def stop(self):
         if not self.proc: