]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
scan-build: fix memleak warning in port parsing
authorVictor Julien <victor@inliniac.net>
Thu, 21 Dec 2017 11:07:46 +0000 (12:07 +0100)
committerVictor Julien <victor@inliniac.net>
Tue, 30 Jan 2018 09:32:17 +0000 (10:32 +0100)
src/detect-engine-port.c

index 72f28c599eca49eb646d297f72e3acb7a3b849d4..0ea5b73b1e6e62004c16144775dc39a5e83e1e0d 100644 (file)
@@ -1047,11 +1047,11 @@ static int DetectPortParseDo(const DetectEngineCtx *de_ctx,
                 temp_rule_var_port = alloc_rule_var_port;
                 r = DetectPortParseDo(de_ctx, head, nhead, temp_rule_var_port,
                                   (negate + n_set) % 2, var_list);
+                SCFree(alloc_rule_var_port);
                 if (r == -1)
                     goto error;
 
                 d_set = 0;
-                SCFree(alloc_rule_var_port);
             } else {
                 if (!((negate + n_set) % 2)) {
                     r = DetectPortParseInsertString(head,address);