wifi: cw1200: Fix potential memory leak in cw1200_bh_rx_helper()

[ Upstream commit 5e88e864118c20e63a1571d0ff0a152e5d684959 ]

In one of the error paths, the memory allocated for skb_rx is not freed.
Fix that by freeing it before returning.

Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Link: https://patch.msgid.link/20251110175316.106591-1-nihaal@cse.iitm.ac.in
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/wireless/st/cw1200/bh.c b/drivers/net/wireless/st/cw1200/bh.c
index 10e019cddcc6545384dec985d9042ba7793a9499..cbb95682d21b2390ad2256df81a6be3fc594b614 100644 (file)
--- a/drivers/net/wireless/st/cw1200/bh.c
+++ b/drivers/net/wireless/st/cw1200/bh.c
@@ -317,10 +317,12 @@ static int cw1200_bh_rx_helper(struct cw1200_common *priv,
 
        if (wsm_id & 0x0400) {
                int rc = wsm_release_tx_buffer(priv, 1);
-               if (WARN_ON(rc < 0))
+               if (WARN_ON(rc < 0)) {
+                       dev_kfree_skb(skb_rx);
                        return rc;
-               else if (rc > 0)
+               } else if (rc > 0) {
                        *tx = 1;
+               }
        }
 
        /* cw1200_wsm_rx takes care on SKB livetime */