]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
x86/apic/32: Remove bigsmp_cpu_present_to_apicid()
authorThomas Gleixner <tglx@linutronix.de>
Tue, 8 Aug 2023 22:03:56 +0000 (15:03 -0700)
committerDave Hansen <dave.hansen@linux.intel.com>
Wed, 9 Aug 2023 18:58:25 +0000 (11:58 -0700)
It's a copy of default_cpu_present_to_apicid() with the omission of the
actual check whether the CPU is present.

This APIC callback should die completely, but the XEN APIC implementation
does something different which needs to be addressed first.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Michael Kelley <mikelley@microsoft.com>
Tested-by: Sohil Mehta <sohil.mehta@intel.com>
Tested-by: Juergen Gross <jgross@suse.com> # Xen PV (dom0 and unpriv. guest)
arch/x86/kernel/apic/bigsmp_32.c

index a26cb4684017692e40c5077ba6997e3e3bf734e4..aba8ce1d3f2482a951dec7ba1aff42da69c955f5 100644 (file)
@@ -43,14 +43,6 @@ static void bigsmp_setup_apic_routing(void)
                nr_ioapics);
 }
 
-static int bigsmp_cpu_present_to_apicid(int mps_cpu)
-{
-       if (mps_cpu < nr_cpu_ids)
-               return (int) per_cpu(x86_cpu_to_apicid, mps_cpu);
-
-       return BAD_APICID;
-}
-
 static void bigsmp_ioapic_phys_id_map(physid_mask_t *phys_map, physid_mask_t *retmap)
 {
        /* For clustered we don't have a good way to do this yet - hack */
@@ -119,7 +111,7 @@ static struct apic apic_bigsmp __ro_after_init = {
        .init_apic_ldr                  = bigsmp_init_apic_ldr,
        .ioapic_phys_id_map             = bigsmp_ioapic_phys_id_map,
        .setup_apic_routing             = bigsmp_setup_apic_routing,
-       .cpu_present_to_apicid          = bigsmp_cpu_present_to_apicid,
+       .cpu_present_to_apicid          = default_cpu_present_to_apicid,
        .apicid_to_cpu_present          = physid_set_mask_of_physid,
        .phys_pkg_id                    = bigsmp_phys_pkg_id,