don't do shallow copy

which makes the string have multiple parents, and causes
talloc complaints in xlat_eval

diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index 69ed3b8d39694ebb9badf5eec304a7ec258306ec..c9d21a03b4b2fc20416b9e9abecc9d6a5e596e1f 100644 (file)
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -1740,7 +1740,7 @@ static inline int fr_value_box_cast_to_strvalue(TALLOC_CTX *ctx, fr_value_box_t
                str = fr_value_box_asprint(ctx, src, '\0');
                if (unlikely(!str)) return -1;
 
-               return fr_value_box_bstrdup_buffer_shallow(ctx, dst, dst_enumv, str, src->tainted);
+               return fr_value_box_bstrdup_buffer(ctx, dst, dst_enumv, str, src->tainted);
        }
        }
 }