storage: Fix the use-after-free memory bug

Introduced by commit e0139e30444. virStorageVolDefFree free'ed the
pointers that are still used by the added volume object, this changes
it back to VIR_FREE.

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 58d0fc0d41f661c06ba4c5e3ed4bbaa347eaa881..323be9e3bfdc2f210c9551ff1eed03a752feaffc 100644 (file)
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -1618,7 +1618,7 @@ storageVolCreateXML(virStoragePoolPtr obj,
 cleanup:
     virObjectUnref(volobj);
     virStorageVolDefFree(voldef);
-    virStorageVolDefFree(buildvoldef);
+    VIR_FREE(buildvoldef);
     if (pool)
         virStoragePoolObjUnlock(pool);
     return ret;