]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
blkid: fix realloc memory leak [cppcheck]
authorSami Kerola <kerolasa@iki.fi>
Sat, 9 Jun 2012 21:05:23 +0000 (23:05 +0200)
committerSami Kerola <kerolasa@iki.fi>
Mon, 11 Jun 2012 17:50:35 +0000 (19:50 +0200)
[misc-utils/blkid.c:367]: (error) Common realloc mistake: 'str' nulled but not freed upon failure

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
misc-utils/blkid.c

index 25e6c00e8e8ebcd5eefef4da4ec27b29d4690df9..840cfe4f621fe4699a55efae4ad0c7a3a31cc961 100644 (file)
@@ -365,8 +365,10 @@ static int append_str(char **res, size_t *sz, const char *a, const char *b)
                return -1;
 
        str = realloc(str, len + 1);
-       if (!str)
+       if (!str) {
+               free(*res);
                return -1;
+       }
 
        *res = str;
        str += *sz;