]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 557686: PostgreSQL crashes when deleting a custom field of type Date/Time
authorFrédéric Buclin <LpSolit@gmail.com>
Wed, 7 Apr 2010 01:02:55 +0000 (03:02 +0200)
committerFrédéric Buclin <LpSolit@gmail.com>
Wed, 7 Apr 2010 01:02:55 +0000 (03:02 +0200)
r=mkanat a=LpSolit

Bugzilla/Field.pm

index 3a7733c3a448f283c05996e72277812013958e93..bd9a4e16ef7f1b7af2b9b64f12fe37fb690342e4 100644 (file)
@@ -721,17 +721,13 @@ sub remove_from_db {
     }
     else {
         $bugs_query = "SELECT COUNT(*) FROM bugs WHERE $name IS NOT NULL";
-        if ($self->type != FIELD_TYPE_BUG_ID) {
+        if ($self->type != FIELD_TYPE_BUG_ID && $self->type != FIELD_TYPE_DATETIME) {
             $bugs_query .= " AND $name != ''";
         }
         # Ignore the default single select value
         if ($self->type == FIELD_TYPE_SINGLE_SELECT) {
             $bugs_query .= " AND $name != '---'";
         }
-        # Ignore blank dates.
-        if ($self->type == FIELD_TYPE_DATETIME) {
-            $bugs_query .= " AND $name != '00-00-00 00:00:00'";
-        }
     }
 
     my $has_bugs = $dbh->selectrow_array($bugs_query);