* docs/storage.html[.in] src/storage_backend_disk.c: revert previous

  msdos patch and apply new one from Cole Robinson
daniel

diff --git a/ChangeLog b/ChangeLog
index 321669c245de2c5234bb08bfa8ddfba8970d9976..2340922e668124bc02c87e126f67ff715a1dc032 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+Wed Aug 13 11:43:36 CEST 2008 Daniel Veillard <veillard@redhat.com>
+
+       * docs/storage.html[.in] src/storage_backend_disk.c: revert previous
+         msdos patch and apply new one from Cole Robinson
+
 Tue Aug 12 19:37:23 CEST 2008 Jim Meyering <meyering@redhat.com>
 
        rewrite virFileLinkPointsTo

diff --git a/docs/storage.html b/docs/storage.html
index 1b82b36862f9569d0158dea7d16507f23aecbcbb..d9d62f7353366301949070a2add3573726022103 100644 (file)
--- a/docs/storage.html
+++ b/docs/storage.html
@@ -331,7 +331,7 @@ libvirt.
       the common partition table types:
     </p>
         <ul><li>
-        <code>msdos</code>
+        <code>dos</code>
       </li><li>
         <code>dvh</code>
       </li><li>
@@ -346,7 +346,7 @@ libvirt.
         <code>sun</code>
       </li></ul>
         <p>
-      The <code>msdos</code> or <code>gpt</code> formats are recommended for
+      The <code>dos</code> or <code>gpt</code> formats are recommended for
       best portability - the latter is needed for disks larger than 2TB.
     </p>
         <h3>Valid volume format types</h3>

diff --git a/docs/storage.html.in b/docs/storage.html.in
index 8cab480b42d29da8c23d5bc7e78b38e104386396..40e8e80da50d1555257b949f7b0033c1f690d5a2 100644 (file)
--- a/docs/storage.html.in
+++ b/docs/storage.html.in
@@ -258,7 +258,7 @@ libvirt.
     </p>
     <ul>
       <li>
-        <code>msdos</code>
+        <code>dos</code>
       </li>
       <li>
         <code>dvh</code>
@@ -280,7 +280,7 @@ libvirt.
       </li>
     </ul>
     <p>
-      The <code>msdos</code> or <code>gpt</code> formats are recommended for
+      The <code>dos</code> or <code>gpt</code> formats are recommended for
       best portability - the latter is needed for disks larger than 2TB.
     </p>
 

diff --git a/src/storage_backend_disk.c b/src/storage_backend_disk.c
index d7d751479527de23179ae1702bd34201960dc7b0..b3e669266b0de8fee851697a408ae0418715ee86 100644 (file)
--- a/src/storage_backend_disk.c
+++ b/src/storage_backend_disk.c
@@ -29,7 +29,7 @@
 #include "memory.h"
 
 enum {
-    VIR_STORAGE_POOL_DISK_MSDOS = 0,
+    VIR_STORAGE_POOL_DISK_DOS = 0,
     VIR_STORAGE_POOL_DISK_DVH,
     VIR_STORAGE_POOL_DISK_GPT,
     VIR_STORAGE_POOL_DISK_MAC,
@@ -64,10 +64,10 @@ static int
 virStorageBackendDiskPoolFormatFromString(virConnectPtr conn,
                                           const char *format) {
     if (format == NULL)
-        return VIR_STORAGE_POOL_DISK_MSDOS;
+        return VIR_STORAGE_POOL_DISK_DOS;
 
-    if (STREQ(format, "msdos"))
-        return VIR_STORAGE_POOL_DISK_MSDOS;
+    if (STREQ(format, "dos"))
+        return VIR_STORAGE_POOL_DISK_DOS;
     if (STREQ(format, "dvh"))
         return VIR_STORAGE_POOL_DISK_DVH;
     if (STREQ(format, "gpt"))
@@ -90,8 +90,8 @@ static const char *
 virStorageBackendDiskPoolFormatToString(virConnectPtr conn,
                                         int format) {
     switch (format) {
-    case VIR_STORAGE_POOL_DISK_MSDOS:
-        return "msdos";
+    case VIR_STORAGE_POOL_DISK_DOS:
+        return "dos";
     case VIR_STORAGE_POOL_DISK_DVH:
         return "dvh";
     case VIR_STORAGE_POOL_DISK_GPT:
@@ -407,7 +407,9 @@ virStorageBackendDiskBuildPool(virConnectPtr conn,
         pool->def->source.devices[0].path,
         "mklabel",
         "--script",
-        virStorageBackendDiskPoolFormatToString(conn, pool->def->source.format),
+        ((pool->def->source.format == VIR_STORAGE_POOL_DISK_DOS) ? "msdos" :
+          virStorageBackendDiskPoolFormatToString(conn,
+                                                  pool->def->source.format)),
         NULL,
     };