]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
cgroup_config_create_template_group: fix strncpy limits
authorIvana Hutarova Varekova <varekova@redhat.com>
Wed, 9 Oct 2013 09:43:25 +0000 (11:43 +0200)
committerIvana Hutarova Varekova <varekova@redhat.com>
Wed, 9 Oct 2013 09:43:25 +0000 (11:43 +0200)
fix strncpy limits in cgroup_config_create_template_group function

Signed-off-by: Ivana Hutarova Varekova <varekova@redhat.com>
Acked-by: Peter Schiffer <pschiffe@redhat.com>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
src/config.c

index 06f559befebaf4f6d8a7a6073594f9f3f02bfbea..eacb490917ba7817412657907a65332d45d007c8 100644 (file)
@@ -1612,14 +1612,14 @@ int cgroup_config_create_template_group(struct cgroup *cgroup,
                                /* name and controller match template found */
                                /* variables substituted in template */
                                strncpy(buffer, t_cgroup->name,
-                                       FILENAME_MAX);
+                                       FILENAME_MAX-1);
                                strncpy(t_cgroup->name, cgroup->name,
-                                       FILENAME_MAX);
+                                       FILENAME_MAX-1);
 
                                ret = cgroup_create_cgroup(t_cgroup, flags);
 
                                strncpy(t_cgroup->name, buffer,
-                                       FILENAME_MAX);
+                                       FILENAME_MAX-1);
                                if (ret) {
                                        cgroup_dbg("creating group %s, error %d\n",
                                        cgroup->name, ret);