mod_asis: Fix the log level of the message AH01236

Change the log level from ERROR to DEBUG.

The message \"mod_asis: ap_pass_brigade failed for file ...\" was logged with
the level ERROR. This log level is inappropriate here, because a client can
trigger this log message by aborting the request.

Most other modules don't log at all or use the log level DEBUG when
ap_pass_brigade() fails.

Submitted by: Michael Kaufmann <mail michael-kaufmann.ch>
Github: closes #527

Add a change entry to give credits to the author.

Merges r1924954, r1926191 trunk
Submitted by: jorton, jailletc36
Reviewed by: jailletc36, rpluem, ylavic

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1926328 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index 891aa5d90e625f5acc3a1bca42468ff064813e34..6fbe3d07379271ebb1a8352c051786833ff229ca 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.4.64
 
+  *) mod_asis: Fix the log level of the message AH01236.
+     Github #527 [Michael Kaufmann <mail michael-kaufmann.ch>]
+
   *) mod_session_dbd: ensure format used with SessionDBDCookieName and
      SessionDBDCookieName2 are correct.
      Github #503 [Thomas Meyer <thomas m3y3r.de>]

diff --git a/modules/generators/mod_asis.c b/modules/generators/mod_asis.c
index c2b651be2cd80fbbb2b49b438b33976bfe6fa44b..28f8387ca9489a22a97735da828abb4c6a1e346e 100644 (file)
--- a/modules/generators/mod_asis.c
+++ b/modules/generators/mod_asis.c
@@ -99,7 +99,7 @@ static int asis_handler(request_rec *r)
         APR_BRIGADE_INSERT_TAIL(bb, b);
         rv = ap_pass_brigade(r->output_filters, bb);
         if (rv != APR_SUCCESS) {
-            ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, APLOGNO(01236)
+            ap_log_rerror(APLOG_MARK, APLOG_DEBUG, rv, r, APLOGNO(01236)
                           "mod_asis: ap_pass_brigade failed for file %s", r->filename);
             return AP_FILTER_ERROR;
         }