data_reg: Add a missing break in nftnl_data_reg_snprintf

The code works fine as-is, but if reg_type == DATA_VALUE &&
output_format == NFTNL_OUTPUT_XML, we fall through to DATA_CHAIN case
and therefore pointlessly check output_format again.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index a246952f7f01be4147582c273ca4aa2ca6eb0b95..70232028869a000fd0e5135d8b4b267d88a774b7 100644 (file)
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -207,6 +207,7 @@ int nftnl_data_reg_snprintf(char *buf, size_t size,
                default:
                        break;
                }
+               break;
        case DATA_VERDICT:
        case DATA_CHAIN:
                switch(output_format) {
@@ -220,6 +221,7 @@ int nftnl_data_reg_snprintf(char *buf, size_t size,
                default:
                        break;
                }
+               break;
        default:
                break;
        }