]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
migration: Remove redundant state change
authorFabiano Rosas <farosas@suse.de>
Fri, 23 Jan 2026 14:16:31 +0000 (11:16 -0300)
committerFabiano Rosas <farosas@suse.de>
Fri, 23 Jan 2026 14:32:16 +0000 (11:32 -0300)
If local_err is set, migration_connect_error_propagate() will be
called and that function already has a state transition from SETUP to
FAILED.

Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20260123141656.6765-2-farosas@suse.de
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/migration.c

index 4062c12d33c2e143585d2115761bd9024893c03a..b46e01b8c0a27e885046e99a5a1edc1222f9b8ea 100644 (file)
@@ -2323,8 +2323,6 @@ static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested,
         file_start_outgoing_migration(s, &addr->u.file, &local_err);
     } else {
         error_setg(&local_err, "uri is not a valid migration protocol");
-        migrate_set_state(&s->state, MIGRATION_STATUS_SETUP,
-                          MIGRATION_STATUS_FAILED);
     }
 
     if (local_err) {