]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
backport: re PR tree-optimization/83523 (ICE: verify_gimple failed (error: statement...
authorJakub Jelinek <jakub@redhat.com>
Mon, 25 Jun 2018 17:04:14 +0000 (19:04 +0200)
committerJakub Jelinek <jakub@gcc.gnu.org>
Mon, 25 Jun 2018 17:04:14 +0000 (19:04 +0200)
Backported from mainline
2017-12-21  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/83523
* tree-ssa-math-opts.c (is_widening_mult_p): Return false if
for INTEGER_TYPE TYPE_OVERFLOW_TRAPS.
(convert_mult_to_fma): Likewise.

* g++.dg/tree-ssa/pr83523.C: New test.

From-SVN: r262048

gcc/ChangeLog
gcc/testsuite/ChangeLog
gcc/testsuite/g++.dg/tree-ssa/pr83523.C [new file with mode: 0644]
gcc/tree-ssa-math-opts.c

index d67b8dbebdcc4c618f0fb9d6c04230844246a7d2..6b73af2cb423f40b601006dc9fe34d91324012f5 100644 (file)
@@ -3,6 +3,11 @@
        Backported from mainline
        2017-12-21  Jakub Jelinek  <jakub@redhat.com>
 
+       PR tree-optimization/83523
+       * tree-ssa-math-opts.c (is_widening_mult_p): Return false if
+       for INTEGER_TYPE TYPE_OVERFLOW_TRAPS.
+       (convert_mult_to_fma): Likewise.
+
        PR tree-optimization/83521
        * tree-ssa-phiopt.c (factor_out_conditional_conversion): Use
        gimple_build_assign without code on result of
index dd21e51e93c90da19d514c09a5ac5ef28daec2ee..f8138962f2720ee2b7ae60ba94ddb847d843adc3 100644 (file)
@@ -3,6 +3,11 @@
        Backported from mainline
        2017-12-21  Jakub Jelinek  <jakub@redhat.com>
 
+       PR tree-optimization/83523
+       * g++.dg/tree-ssa/pr83523.C: New test.
+
+       2017-12-21  Jakub Jelinek  <jakub@redhat.com>
+
        PR tree-optimization/83521
        * gcc.dg/pr83521.c: New test.
 
diff --git a/gcc/testsuite/g++.dg/tree-ssa/pr83523.C b/gcc/testsuite/g++.dg/tree-ssa/pr83523.C
new file mode 100644 (file)
index 0000000..d9adf90
--- /dev/null
@@ -0,0 +1,25 @@
+// PR tree-optimization/83523
+// { dg-do compile }
+// { dg-options "-O2 -fexceptions -fnon-call-exceptions -ftrapv" }
+
+#ifdef __SIZEOF_INT128__
+typedef __int128 T;
+typedef long long int U;
+#else
+typedef long long int T;
+typedef int U;
+#endif
+
+struct S { S (); ~S (); };
+void bar ();
+
+T
+foo (U x, U y)
+{
+  T z = x;
+  S s;
+  bar ();
+  z *= y;
+  bar ();
+  return z;
+}
index 6413bd6d1ae17d04e276d97c088497d6d334823c..71315dc42793b2e6244b5730e2ecd870d2dea04a 100644 (file)
@@ -3030,8 +3030,12 @@ is_widening_mult_p (gimple *stmt,
 {
   tree type = TREE_TYPE (gimple_assign_lhs (stmt));
 
-  if (TREE_CODE (type) != INTEGER_TYPE
-      && TREE_CODE (type) != FIXED_POINT_TYPE)
+  if (TREE_CODE (type) == INTEGER_TYPE)
+    {
+      if (TYPE_OVERFLOW_TRAPS (type))
+       return false;
+    }
+  else if (TREE_CODE (type) != FIXED_POINT_TYPE)
     return false;
 
   if (!is_widening_mult_rhs_p (type, gimple_assign_rhs1 (stmt), type1_out,
@@ -3399,7 +3403,8 @@ convert_mult_to_fma (gimple *mul_stmt, tree op1, tree op2)
   /* We don't want to do bitfield reduction ops.  */
   if (INTEGRAL_TYPE_P (type)
       && (TYPE_PRECISION (type)
-         != GET_MODE_PRECISION (TYPE_MODE (type))))
+         != GET_MODE_PRECISION (TYPE_MODE (type))
+         || TYPE_OVERFLOW_TRAPS (type)))
     return false;
 
   /* If the target doesn't support it, don't generate it.  We assume that