s3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()

All callers expect 0 an success and -1 on error.

metze
(cherry picked from commit a255f9ce713b29552722ec73e4038226959e1c8e)
(cherry picked from commit 9aa543fee7ebcc95125d18868bdec7e4bf577d8a)

diff --git a/source/include/proto.h b/source/include/proto.h
index db47e2fbdba812c68e9cbddb961bf5d198eb3870..cc8e7406adaa13092c79ecc6f3a699a582124860 100644 (file)
--- a/source/include/proto.h
+++ b/source/include/proto.h
@@ -460,7 +460,7 @@ int32_t dbwrap_fetch_int32(struct db_context *db, const char *keystr);
 int dbwrap_store_int32(struct db_context *db, const char *keystr, int32_t v);
 bool dbwrap_fetch_uint32(struct db_context *db, const char *keystr,
                         uint32_t *val);
-bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v);
+int dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v);
 uint32_t dbwrap_change_uint32_atomic(struct db_context *db, const char *keystr,
                                     uint32_t *oldval, uint32_t change_val);
 int32 dbwrap_change_int32_atomic(struct db_context *db, const char *keystr,

diff --git a/source/lib/dbwrap_util.c b/source/lib/dbwrap_util.c
index ddc613150bbd77ef69ec57a00faa641178faeac1..3be3a49e7defc623305e088d8fa0b086431b79fc 100644 (file)
--- a/source/lib/dbwrap_util.c
+++ b/source/lib/dbwrap_util.c
@@ -78,7 +78,7 @@ bool dbwrap_fetch_uint32(struct db_context *db, const char *keystr,
        return true;
 }
 
-bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v)
+int dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v)
 {
        struct db_record *rec;
        uint32 v_store;
@@ -86,7 +86,7 @@ bool dbwrap_store_uint32(struct db_context *db, const char *keystr, uint32_t v)
 
        rec = db->fetch_locked(db, NULL, string_term_tdb_data(keystr));
        if (rec == NULL) {
-               return false;
+               return -1;
        }
 
        SIVAL(&v_store, 0, v);